refactor(verify): delegate cert-chain verification to agent-manifest 0.5#60
Merged
Conversation
Removes ca2a's last duplicated attestation crypto. ca2a_verify.verify_cert_chain (shared by the SEV-SNP VCEK, TDX PCK, and TPM AK chains) now delegates to agent_manifest.verify_cert_chain, the org's shared generic algorithm-agnostic verifier, re-raising CertChainError as AttestationFailed to preserve ca2a's contract. ca2a keeps its own parsers, per-format signature checks, appraisal shapes, trust-root pinning, and verify_offer semantics. Dep: adds agent-manifest>=0.5. 201 tests pass unchanged; ruff + mypy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates ca2a's attestation crypto onto agent-manifest's shared verification library (0.5.0, via PyPI) — removing the org's last duplicated certificate-chain verifier.
What changed
ca2a_verify.verify_cert_chain— used identically by the SEV-SNP VCEK chain, the TDX PCK chain, and the TPM AK chain — is now a thin wrapper overagent_manifest.verify_cert_chain(the generic, algorithm-agnostic verifier: EC / RSA-PSS / RSA-PKCS#1 v1.5, fingerprint-pinned root). ItsCertChainErroris re-raised as ca2a'sAttestationFailedso the error contract is unchanged.What stays local (deliberately)
ca2a's report/quote parsers, per-format signature checks, appraisal/assurance result shapes, caller-supplied trust-root pinning, and
verify_offersemantics — ca2a orchestration, not shared crypto.Guarantees
Behavior unchanged, no check weakened. The chain tests (incl. the real AMD Milan ARK/ASK and Intel SGX Root CA fixtures) still pass on the shared verifier. All 201 tests pass unchanged; ruff + mypy clean. Adds
agent-manifest>=0.5.With this + cmcp#413, all three repos (agent-manifest, cmcp, ca2a) share one verification library via PyPI; no duplicated attestation crypto remains.
🤖 Generated with Claude Code